Skip to content

fix: fix doc store mixin to use correct doc store method - #12045

Merged
sjrl merged 3 commits into
mainfrom
fix-mixin
Jul 17, 2026
Merged

fix: fix doc store mixin to use correct doc store method#12045
sjrl merged 3 commits into
mainfrom
fix-mixin

Conversation

@sjrl

@sjrl sjrl commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Related Issues

  • fixes #issue-number

Proposed Changes:

Update the test_count_unique_metadata_by_filter_with_multiple_filters to correctly use the count_unique_metadata_by_filter instead of count_documents_by_filter. The async version was already using the correct method.

How did you test it?

Existing tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl
sjrl requested a review from a team as a code owner July 17, 2026 08:48
@sjrl
sjrl requested review from julian-risch and removed request for a team July 17, 2026 08:48
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jul 17, 2026 9:14am

Request Review

@sjrl sjrl self-assigned this Jul 17, 2026
@github-actions github-actions Bot added the type:documentation Improvements on the docs label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@julian-risch julian-risch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjrl
sjrl enabled auto-merge (squash) July 17, 2026 09:17
@sjrl
sjrl merged commit 07b8d93 into main Jul 17, 2026
24 checks passed
@sjrl
sjrl deleted the fix-mixin branch July 17, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants